Remove string_view_metadata
string_view_metadata was introduced to make compiled format relocatable. However, format string compilation is an optimization and therefore adding overhead and extra complexity for relocation is undesirable. In most cases the string will be either static or outlive compilation and formatting and if it doesn't, it's possible to make compiled representation relocatale by other means.
This commit is contained in:
@@ -738,8 +738,7 @@ struct formatter<std::chrono::duration<Rep, Period>, Char> {
|
||||
|
||||
FMT_CONSTEXPR arg_ref_type make_arg_ref(basic_string_view<Char> arg_id) {
|
||||
context.check_arg_id(arg_id);
|
||||
const auto str_val = internal::string_view_metadata(format_str, arg_id);
|
||||
return arg_ref_type(str_val);
|
||||
return arg_ref_type(arg_id);
|
||||
}
|
||||
|
||||
FMT_CONSTEXPR arg_ref_type make_arg_ref(internal::auto_id) {
|
||||
|
||||
Reference in New Issue
Block a user