leavelet/fmt
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix bug re: return type of f(un)lockfile wrappers for Windows (#4739)

Browse Source 
Just a tiny bugfix I spotted: The `f(un)lockfile` wrappers in
`format-inl.h` that wrap Windows's `_(un)lock_file` methods are
defined with a trailing return type derived by using decltype on a
hypothetical call to the underlying functions.

The wrappers don't contain a `return` in their bodies, however, so if
the return type of the underlying functions were to ever change from
`void`, there would be a compile error. This just adds `return` to each.
This commit is contained in:
Mike Vastola
2026-04-10 11:01:13 -04:00
committed by GitHub
parent 9396f77fe4
commit be98ea8add
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
include/fmt/format-inl.h
View File

@@ -1477,10 +1477,10 @@ template <typename T> struct span {
};
template <typename F> auto flockfile(F* f) -> decltype(_lock_file(f)) {
_lock_file(f);
return _lock_file(f);
}
template <typename F> auto funlockfile(F* f) -> decltype(_unlock_file(f)) {
_unlock_file(f);
return _unlock_file(f);
}
#ifndef getc_unlocked