leaveletandClaude Fable 5
698a3e2431
dfa168abe9made duplicate ack completion idempotent at the consumer (writing_check), which is correct and lock-balance-safe but masks the producer invariant breach: two acks can only coexist for one radix registration when an ack is orphaned in ack_write_queue after a rollback cleared ongoing_write_through/pending_host_backups, re-opening the _node_host_write_pending guard for a fresh registration. _rollback_pending_backup (write_backup's exception path) was the one rollback that did not scrub the node's acks — and it also left a half-submitted layer-write state alive, which later forwards would keep driving, writing D2H into host slots the rollback had already evicted. Close the invariant structurally: - reserve_write_cp refuses (HiCacheWriteFailure, the existing skip-this-round path both callers already handle) when the node still has an undrained final ack, computed by scanning the small ack queue — no new state to keep in sync. - _rollback_pending_backup now cancels the pending layer-write state (write-stream sync so in-flight per-layer copies finish before the host slots are evicted) and scrubs the node's queued acks via the scrub factored out of _rollback_prepared_cp_backup. - The consumer-side duplicate guard fromdfa168abe9is kept as defense in depth. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Registered Tests
Tests under this directory are auto-discovered by run_suite.py via CI registration decorators.
Where Should I Put My New Test?
No server / engine launch required
| What you're testing | Directory | Requires |
|---|---|---|
| Component logic in isolation (cache, scheduler, config, parser, etc.) | unit/<module>/ |
CPU or GPU |
| CUDA kernel correctness | kernels/ |
GPU |
Server / engine launch required (E2E)
| What you're testing | Directory | Requires |
|---|---|---|
| Model inference correctness | models/, 4-gpu-models/, 8-gpu-models/ |
GPU |
| Feature-specific (OpenAI API, LoRA, speculative, distributed, VLM, etc.) | openai_server/, lora/, spec/, distributed/, ... |
GPU |
| Benchmarks (performance, accuracy, stress) | benchmark/ |
GPU |
| Platform-specific | amd/, ascend/ |
Vendor GPU |
See unit/README.md for unit test conventions.