Support JSON format request logging for easier parsing (#15743)

This commit is contained in:
fzyzcjy
2025-12-24 19:52:43 +08:00
committed by GitHub
parent c6a6ba4368
commit e245cac0c5
5 changed files with 140 additions and 13 deletions

View File

@@ -1,4 +1,5 @@
import io
import json
import unittest
import requests
@@ -12,15 +13,16 @@ from sglang.test.test_utils import (
popen_launch_server,
)
register_cuda_ci(est_time=60, suite="nightly-1-gpu", nightly=True)
register_cuda_ci(est_time=120, suite="nightly-1-gpu", nightly=True)
class TestRequestLogger(CustomTestCase):
class BaseTestRequestLogger:
log_requests_format = None
@classmethod
def setUpClass(cls):
cls.stdout = io.StringIO()
cls.stderr = io.StringIO()
cls.process = popen_launch_server(
"Qwen/Qwen3-0.6B",
DEFAULT_URL_FOR_TEST,
@@ -29,6 +31,8 @@ class TestRequestLogger(CustomTestCase):
"--log-requests",
"--log-requests-level",
"2",
"--log-requests-format",
cls.log_requests_format,
"--skip-server-warmup",
],
return_stdout_stderr=(cls.stdout, cls.stderr),
@@ -40,7 +44,7 @@ class TestRequestLogger(CustomTestCase):
cls.stdout.close()
cls.stderr.close()
def test_request_logging(self):
def _send_request(self):
response = requests.post(
DEFAULT_URL_FOR_TEST + "/generate",
json={
@@ -50,11 +54,43 @@ class TestRequestLogger(CustomTestCase):
timeout=30,
)
self.assertEqual(response.status_code, 200)
return self.stdout.getvalue() + self.stderr.getvalue()
combined_output = self.stdout.getvalue() + self.stderr.getvalue()
class TestRequestLoggerText(BaseTestRequestLogger, CustomTestCase):
log_requests_format = "text"
def test_text_format_logging(self):
combined_output = self._send_request()
self.assertIn("Receive:", combined_output)
self.assertIn("Finish:", combined_output)
class TestRequestLoggerJson(BaseTestRequestLogger, CustomTestCase):
log_requests_format = "json"
def test_json_format_logging(self):
combined_output = self._send_request()
received_found = False
finished_found = False
for line in combined_output.splitlines():
if not line.startswith("{"):
continue
data = json.loads(line)
if data.get("event") == "request.received":
self.assertIn("rid", data)
self.assertIn("obj", data)
received_found = True
elif data.get("event") == "request.finished":
self.assertIn("rid", data)
self.assertIn("obj", data)
self.assertIn("out", data)
finished_found = True
self.assertTrue(received_found, "request.received event not found in logs")
self.assertTrue(finished_found, "request.finished event not found in logs")
if __name__ == "__main__":
unittest.main()