fix: fail fast for CP HiCache storage args
This commit is contained in:
@@ -372,50 +372,28 @@ class TestHiCacheArgs(CustomTestCase):
|
||||
self.assertEqual(args.decode_attention_backend, expected_decode_backend)
|
||||
|
||||
def test_cp_shared_kv_rejects_hicache_storage_backend(self):
|
||||
args = self._make_args(
|
||||
enable_hierarchical_cache=True,
|
||||
enable_nsa_prefill_context_parallel=True,
|
||||
enable_nsa_prefill_cp_shared_kv=True,
|
||||
nsa_prefill_cp_mode="in-seq-split",
|
||||
disaggregation_mode=None,
|
||||
page_size=64,
|
||||
enable_hisparse=False,
|
||||
hicache_storage_backend="mooncake",
|
||||
tp_size=8,
|
||||
)
|
||||
pre_call_state = (
|
||||
args.enable_dp_attention,
|
||||
args.moe_dense_tp_size,
|
||||
args.moe_a2a_backend,
|
||||
args.ep_size,
|
||||
args.attn_cp_size,
|
||||
args.page_size,
|
||||
)
|
||||
|
||||
with (
|
||||
self.assertRaisesRegex(
|
||||
AssertionError,
|
||||
"enable_nsa_prefill_cp_shared_kv.*hicache_storage_backend",
|
||||
),
|
||||
patch.object(
|
||||
args,
|
||||
ServerArgs,
|
||||
"get_model_config",
|
||||
side_effect=AssertionError("get_model_config should not be called"),
|
||||
),
|
||||
):
|
||||
args._handle_model_specific_adjustments()
|
||||
|
||||
self.assertEqual(
|
||||
pre_call_state,
|
||||
(
|
||||
args.enable_dp_attention,
|
||||
args.moe_dense_tp_size,
|
||||
args.moe_a2a_backend,
|
||||
args.ep_size,
|
||||
args.attn_cp_size,
|
||||
args.page_size,
|
||||
),
|
||||
)
|
||||
ServerArgs(
|
||||
model_path="dummy",
|
||||
enable_hierarchical_cache=True,
|
||||
enable_nsa_prefill_context_parallel=True,
|
||||
enable_nsa_prefill_cp_shared_kv=True,
|
||||
nsa_prefill_cp_mode="in-seq-split",
|
||||
disaggregation_mode="null",
|
||||
page_size=64,
|
||||
enable_hisparse=False,
|
||||
hicache_storage_backend="mooncake",
|
||||
)
|
||||
|
||||
def test_hicache_io_backend_and_mem_layout_compatibility(self):
|
||||
cases = [
|
||||
|
||||
Reference in New Issue
Block a user