diff --git a/test/registered/lora/test_lora_eviction.py b/test/registered/lora/test_lora_eviction.py index 4404d11ec..3ed9ea176 100644 --- a/test/registered/lora/test_lora_eviction.py +++ b/test/registered/lora/test_lora_eviction.py @@ -101,17 +101,7 @@ class TestLoRAEviction(CustomTestCase): max_loras_per_batch=1, enable_lora=True, max_lora_rank=256, - # Need to list all lora modules, or "all" might include lora modules without assigning lora weights - # lora_target_modules=["all"], - lora_target_modules=[ - "q_proj", - "k_proj", - "v_proj", - "o_proj", - "gate_proj", - "up_proj", - "down_proj", - ], + lora_target_modules=["all"], ) as srt_runner: adapter_sequence = lora_paths if not reverse else lora_paths[::-1] diff --git a/test/registered/lora/test_lora_update.py b/test/registered/lora/test_lora_update.py index d1a7aad6e..a7ae1aa58 100644 --- a/test/registered/lora/test_lora_update.py +++ b/test/registered/lora/test_lora_update.py @@ -221,17 +221,7 @@ BASIC_TESTS = [ base="meta-llama/Llama-3.1-8B-Instruct", enable_lora=True, max_lora_rank=256, - # Need to list all lora modules, or "all" might include lora modules without assigning lora weights - # lora_target_modules=["all"], - lora_target_modules=[ - "q_proj", - "k_proj", - "v_proj", - "o_proj", - "gate_proj", - "up_proj", - "down_proj", - ], + lora_target_modules=["all"], max_loras_per_batch=4, all_adapters=[ "philschmid/code-llama-3-1-8b-text-to-sql-lora", @@ -350,17 +340,7 @@ TARGET_MODULE_TESTS = [ description="Test explicitly specified lora-target-modules.", base="meta-llama/Llama-3.1-8B-Instruct", max_loras_per_batch=3, - # Need to list all lora modules, or "all" might include lora modules without assigning lora weights - # lora_target_modules=["all"], - lora_target_modules=[ - "q_proj", - "k_proj", - "v_proj", - "o_proj", - "gate_proj", - "up_proj", - "down_proj", - ], + lora_target_modules=["all"], max_lora_rank=64, all_adapters=[ "Nutanix/Meta-Llama-3.1-8B-Instruct_lora_4_alpha_16", # target_modules = q, k, v, o, gate, up, down @@ -766,17 +746,7 @@ EVICTION_TESTS = [ ], enable_lora=True, max_lora_rank=256, - # Need to list all lora modules, or "all" might include lora modules without assigning lora weights - # lora_target_modules=["all"], - lora_target_modules=[ - "q_proj", - "k_proj", - "v_proj", - "o_proj", - "gate_proj", - "up_proj", - "down_proj", - ], + lora_target_modules=["all"], op_sequence=[ Operation( type=OperationType.LOAD, @@ -1528,17 +1498,7 @@ class TestLoRADynamicUpdate(CustomTestCase): lora_paths=[], max_loras_per_batch=2, max_lora_rank=256, - # Need to list all lora modules, or "all" might include lora modules without assigning lora weights - # lora_target_modules=["all"], - lora_target_modules=[ - "q_proj", - "k_proj", - "v_proj", - "o_proj", - "gate_proj", - "up_proj", - "down_proj", - ], + lora_target_modules=["all"], enable_lora=True, ) as session: # Test with no adapters loaded diff --git a/test/registered/rl/test_lora_load_from_tensor.py b/test/registered/rl/test_lora_load_from_tensor.py index a5c4e7e3b..af1641cd3 100644 --- a/test/registered/rl/test_lora_load_from_tensor.py +++ b/test/registered/rl/test_lora_load_from_tensor.py @@ -29,15 +29,7 @@ class TestLoRALoadFromTensor(CustomTestCase): model_path=MODEL_PATH, enable_lora=True, max_lora_rank=64, - lora_target_modules=[ - "q_proj", - "k_proj", - "v_proj", - "o_proj", - "gate_proj", - "up_proj", - "down_proj", - ], + lora_target_modules=["all"], mem_fraction_static=0.6, log_level="error", ) @@ -61,15 +53,7 @@ class TestLoRALoadFromTensor(CustomTestCase): model_path=MODEL_PATH, enable_lora=True, max_lora_rank=64, - lora_target_modules=[ - "q_proj", - "k_proj", - "v_proj", - "o_proj", - "gate_proj", - "up_proj", - "down_proj", - ], + lora_target_modules=["all"], mem_fraction_static=0.6, log_level="error", max_loaded_loras=MAX_LOADED_LORAS,