From b5eb0214caeeef44ec0f5475e755d178e01b0afb Mon Sep 17 00:00:00 2001 From: Simo Lin Date: Fri, 19 Dec 2025 10:57:18 -1000 Subject: [PATCH] [model-gateway] Improve logging in data_connector module (#15495) --- sgl-model-gateway/src/data_connector/factory.rs | 2 -- sgl-model-gateway/src/data_connector/memory.rs | 8 +++++--- sgl-model-gateway/src/data_connector/postgres.rs | 3 ++- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/sgl-model-gateway/src/data_connector/factory.rs b/sgl-model-gateway/src/data_connector/factory.rs index 5c62934df..879137a6b 100644 --- a/sgl-model-gateway/src/data_connector/factory.rs +++ b/sgl-model-gateway/src/data_connector/factory.rs @@ -1,8 +1,6 @@ // factory.rs // // Factory function to create storage backends based on configuration. -// This centralizes storage initialization logic and fixes the bug where -// conversation_item_storage was missing/incorrect in server.rs. use std::sync::Arc; diff --git a/sgl-model-gateway/src/data_connector/memory.rs b/sgl-model-gateway/src/data_connector/memory.rs index 74df6d98d..ed029931d 100644 --- a/sgl-model-gateway/src/data_connector/memory.rs +++ b/sgl-model-gateway/src/data_connector/memory.rs @@ -332,9 +332,11 @@ impl ResponseStorage for MemoryResponseStorage { .push(response_id.clone()); } - // Store the response store.responses.insert(response_id.clone(), response); - tracing::info!("memory_store_size" = store.responses.len()); + tracing::debug!( + memory_store_size = store.responses.len(), + "Response stored in memory" + ); Ok(response_id) } @@ -345,7 +347,7 @@ impl ResponseStorage for MemoryResponseStorage { ) -> ResponseResult> { let store = self.store.read(); let result = store.responses.get(response_id).cloned(); - tracing::info!("memory_get_response" = %response_id.0, found = result.is_some()); + tracing::debug!(response_id = %response_id.0, found = result.is_some(), "Memory response lookup"); Ok(result) } diff --git a/sgl-model-gateway/src/data_connector/postgres.rs b/sgl-model-gateway/src/data_connector/postgres.rs index 96aabde1d..48670fe60 100644 --- a/sgl-model-gateway/src/data_connector/postgres.rs +++ b/sgl-model-gateway/src/data_connector/postgres.rs @@ -13,6 +13,7 @@ use chrono::{DateTime, Utc}; use deadpool_postgres::{Manager, ManagerConfig, Pool, RecyclingMethod}; use serde_json::Value; use tokio_postgres::{NoTls, Row}; +use tracing; use crate::{ config::PostgresConfig, @@ -588,7 +589,7 @@ impl ResponseStorage for PostgresResponseStorage { &conversation_id, &json_raw_response, ]).await.unwrap(); - println!("INSERT INTO responses VALUES {insert_count}"); + tracing::debug!(rows_affected = insert_count, "Response stored in Postgres"); Ok(response_id) }