From b5d3998508c0f0f874ceae713e744b829d4371d1 Mon Sep 17 00:00:00 2001 From: sglang-bot Date: Thu, 4 Dec 2025 18:24:54 -0800 Subject: [PATCH] Rename secrets.WHL_TOKEN -> secrets.GH_PAT_FOR_WHL_RELEASE (#14421) Co-authored-by: Lianmin Zheng --- .github/MAINTAINER.md | 2 +- .github/pull_request_template.md | 2 +- .github/workflows/cancel-all-pending-pr-test-runs.yml | 10 +++++++--- .github/workflows/release-whl-kernel.yml | 4 ++-- docs/developer_guide/contribution_guide.md | 2 +- scripts/ci/ci_install_deepep.sh | 2 +- scripts/ci/ci_install_dependency.sh | 2 +- 7 files changed, 14 insertions(+), 10 deletions(-) diff --git a/.github/MAINTAINER.md b/.github/MAINTAINER.md index 634f11cdf..cc569f145 100644 --- a/.github/MAINTAINER.md +++ b/.github/MAINTAINER.md @@ -37,7 +37,7 @@ __Note__: The permissions to trigger CI tests are defined separately according t - **Ideal case:** For each modified file, one Codeowner has approved the PR. The PR has also passed the required CI tests. Then, anyone with write permission can merge the PR. - **Exception:** In cases where it is difficult to meet all requirements (due to flaky CI or slow responses), a Merge Oncall can bypass branch protection to merge the PR. -If you meet any issues during the merge, you can discuss in [slack channels](https://slack.sglang.ai/): #dev, #pull-request, and #ci-cd-build-release. +If you meet any issues during the merge, you can discuss in [slack channels](https://slack.sglang.io/): #dev, #pull-request, and #ci-cd-build-release. ## The List of Merge Oncalls and Reviewers The format is @github-username (Slack username). diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 7696bc51b..ad9dabd7b 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,4 +1,4 @@ - + ## Motivation diff --git a/.github/workflows/cancel-all-pending-pr-test-runs.yml b/.github/workflows/cancel-all-pending-pr-test-runs.yml index 6217542e7..0f2fe2af8 100644 --- a/.github/workflows/cancel-all-pending-pr-test-runs.yml +++ b/.github/workflows/cancel-all-pending-pr-test-runs.yml @@ -32,14 +32,18 @@ jobs: for workflow_file in "${WORKFLOW_FILES[@]}"; do echo "--- Checking workflow: $workflow_file ---" + + # Fetch list and pipe to while loop gh run list \ --repo "$REPO" \ --workflow "$workflow_file" \ --json databaseId,status \ --limit 1000 \ - | jq -r '.[] | select(.status=="queued" or .status=="in_progress") | .databaseId' \ + | jq -r '.[] | select(.status=="queued" or .status=="in_progress" or .status=="waiting") | .databaseId' \ | while read run_id; do - echo "Cancelling run ID: $run_id for workflow: $workflow_file" - gh run cancel "$run_id" --repo "$REPO" + echo "Attempting to cancel run ID: $run_id for workflow: $workflow_file" + + # The "|| echo ..." part prevents the script from crashing if cancellation fails + gh run cancel "$run_id" --repo "$REPO" || echo "⚠️ Could not cancel run $run_id (it may have already completed). Continuing..." done done diff --git a/.github/workflows/release-whl-kernel.yml b/.github/workflows/release-whl-kernel.yml index 4f0a33efb..516e3ea58 100644 --- a/.github/workflows/release-whl-kernel.yml +++ b/.github/workflows/release-whl-kernel.yml @@ -88,14 +88,14 @@ jobs: with: tag_name: ${{ steps.set_tag_name.outputs.tag_name }} repository: sgl-project/whl - token: ${{ secrets.WHL_TOKEN }} + token: ${{ secrets.GH_PAT_FOR_WHL_RELEASE }} files: | sgl-kernel/dist/* - name: Clone wheel index run: git clone https://oauth2:${WHL_TOKEN}@github.com/sgl-project/whl.git sgl-whl env: - WHL_TOKEN: ${{ secrets.WHL_TOKEN }} + WHL_TOKEN: ${{ secrets.GH_PAT_FOR_WHL_RELEASE }} - name: Update wheel index run: python3 scripts/update_kernel_whl_index.py --cuda 129 diff --git a/docs/developer_guide/contribution_guide.md b/docs/developer_guide/contribution_guide.md index 6a5056ce9..7ef5164f9 100644 --- a/docs/developer_guide/contribution_guide.md +++ b/docs/developer_guide/contribution_guide.md @@ -135,6 +135,6 @@ Follow these steps: If you want to contribute but don’t have a specific idea in mind, pick issues labeled [“good first issue” or “help wanted”](https://github.com/sgl-project/sglang/issues?q=is%3Aissue+label%3A%22good+first+issue%22%2C%22help+wanted%22). These tasks typically have lower complexity and provide an excellent introduction to the codebase. Also check out this [code walk-through](https://github.com/zhaochenyang20/Awesome-ML-SYS-Tutorial/tree/main/sglang/code-walk-through) for a deeper look into SGLang’s workflow. -If you have any questions or want to start a discussion, please feel free to ask in our [Slack channel](https://slack.sglang.ai). +If you have any questions or want to start a discussion, please feel free to ask in our [Slack channel](https://slack.sglang.io). Thank you for your interest in SGLang. Happy coding! diff --git a/scripts/ci/ci_install_deepep.sh b/scripts/ci/ci_install_deepep.sh index 738ac7612..2f5264305 100755 --- a/scripts/ci/ci_install_deepep.sh +++ b/scripts/ci/ci_install_deepep.sh @@ -21,7 +21,7 @@ if python3 -c "import deep_ep" >/dev/null 2>&1; then fi # Install system dependencies -apt install -y curl wget git sudo libibverbs-dev rdma-core infiniband-diags openssh-server perftest ibverbs-providers libibumad3 libibverbs1 libnl-3-200 libnl-route-3-200 librdmacm1 build-essential cmake +apt install -y curl wget git sudo rdma-core infiniband-diags openssh-server perftest libibumad3 libibverbs-dev libibverbs1 ibverbs-providers ibverbs-utils libnl-3-200 libnl-route-3-200 librdmacm1 build-essential cmake # Install GDRCopy rm -rf /opt/gdrcopy && mkdir -p /opt/gdrcopy diff --git a/scripts/ci/ci_install_dependency.sh b/scripts/ci/ci_install_dependency.sh index d2370e18d..7d0735602 100755 --- a/scripts/ci/ci_install_dependency.sh +++ b/scripts/ci/ci_install_dependency.sh @@ -25,7 +25,7 @@ echo "CUDA_VISIBLE_DEVICES=${CUDA_VISIBLE_DEVICES:-}" python3 -c 'import os, shutil, tempfile, getpass; cache_dir = os.environ.get("TORCHINDUCTOR_CACHE_DIR") or os.path.join(tempfile.gettempdir(), "torchinductor_" + getpass.getuser()); shutil.rmtree(cache_dir, ignore_errors=True)' # Install apt packages -apt install -y git libnuma-dev libssl-dev pkg-config +apt install -y git libnuma-dev libssl-dev pkg-config libibverbs-dev libibverbs1 ibverbs-providers ibverbs-utils # Check if protoc of correct architecture is already installed if command -v protoc >/dev/null 2>&1; then