diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 8374ba4f0..45db320d5 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -28,5 +28,6 @@ 1. Ping Merge Oncalls to start the PR flow. See the [PR Merge Process](https://github.com/sgl-project/sglang/blob/main/.github/MAINTAINER.md#pull-request-merge-process). 2. Get approvals from [CODEOWNERS](https://github.com/sgl-project/sglang/blob/main/.github/CODEOWNERS) and other reviewers. -3. Trigger CI tests with [comments](https://docs.sglang.io/developer_guide/contribution_guide.html#how-to-trigger-ci-tests) (`/tag-run-ci-label`, `/rerun-failed-ci`, `/tag-and-rerun-ci`) or contact authorized users to do so. +3. Trigger CI tests with [comments](https://docs.sglang.io/developer_guide/contribution_guide.html#how-to-trigger-ci-tests) or contact authorized users to do so. + - `/tag-run-ci-label`, `/rerun-failed-ci`, `/tag-and-rerun-ci` 4. After green CI and required approvals, ask Merge Oncalls to merge. diff --git a/.github/workflows/cancel-unfinished-pr-tests.yml b/.github/workflows/cancel-unfinished-pr-tests.yml index c4f9116a0..2c0e9f63f 100644 --- a/.github/workflows/cancel-unfinished-pr-tests.yml +++ b/.github/workflows/cancel-unfinished-pr-tests.yml @@ -1,4 +1,4 @@ -name: Cancel Unfinished PR Tests +name: Cancel Unfinished PR Runs on: workflow_dispatch: @@ -15,7 +15,7 @@ permissions: pull-requests: read # needed for gh pr view (labels) jobs: - cancel-pending-pr-test: + cancel-unfinished-pr-runs: runs-on: ubuntu-latest steps: - name: Install GitHub CLI diff --git a/docs/developer_guide/contribution_guide.md b/docs/developer_guide/contribution_guide.md index 49f70f7df..dde033771 100644 --- a/docs/developer_guide/contribution_guide.md +++ b/docs/developer_guide/contribution_guide.md @@ -90,6 +90,8 @@ If you don’t have permission, please ask maintainers to trigger CI for you. ### CI rate limits +Due to CI scheduling and limited resources, higher-priority PRs may preempt running jobs. In such cases, you may need to rerun the tests. + We apply CI rate limits to prevent abuse and ensure fair usage of our CI resources. Each CI workflow has a default limit defined in its workflow configuration file. For example, in [pr-gate.yml](https://github.com/sgl-project/sglang/blob/main/.github/workflows/pr-gate.yml), the default cooldown period is 120 minutes, and each workflow can override it via the `cool-down-minutes` input parameter: