From 6ce36b12323b8245650595019df52a8cef6dc990 Mon Sep 17 00:00:00 2001 From: Douglas Yang Date: Thu, 11 Dec 2025 18:19:57 -0800 Subject: [PATCH] fix: making the publish trace error check broader (#14931) --- scripts/ci/publish_traces.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/scripts/ci/publish_traces.py b/scripts/ci/publish_traces.py index 639700974..9805f55cb 100644 --- a/scripts/ci/publish_traces.py +++ b/scripts/ci/publish_traces.py @@ -14,12 +14,8 @@ from urllib.request import Request, urlopen def is_rate_limit_error(e): - """Check if an exception is a rate limit error""" - return ( - isinstance(e, HTTPError) - and e.code in [403, 429] - and "rate limit exceeded" in getattr(e, "error_body", "").lower() - ) + """Check if an exception is a GitHub permission/quota error that should not be retried""" + return isinstance(e, HTTPError) and e.code in [403, 429] def make_github_request(url, token, method="GET", data=None):