From 414248e0d0810155ae38dc191cf95e1806634116 Mon Sep 17 00:00:00 2001 From: Mick Date: Mon, 24 Nov 2025 13:00:08 +0800 Subject: [PATCH] [diffusion] doc: minor update contributing.md with test section (#13792) Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --- python/sglang/multimodal_gen/docs/contributing.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/python/sglang/multimodal_gen/docs/contributing.md b/python/sglang/multimodal_gen/docs/contributing.md index 960fc7a97..fb8b4456b 100644 --- a/python/sglang/multimodal_gen/docs/contributing.md +++ b/python/sglang/multimodal_gen/docs/contributing.md @@ -44,3 +44,13 @@ For PRs that impact **latency**, **throughput**, or **memory usage**, you **shou ... ``` 4. **Paste**: paste the table into the PR description + +## 3. CI-Based Change Protection + +Consider adding tests to the `pr-test` or `nightly-test` suites to safeguard your changes, especially for PRs that: + +1. support a new model +2. support or fix important features +3. significantly improve performance + +See [test](https://github.com/sgl-project/sglang/tree/main/python/sglang/multimodal_gen/test) for examples