From 36d147121fff73017faa3914cef19a85bfbbfc4f Mon Sep 17 00:00:00 2001 From: Hubert Lu <55214931+hubertlu-tw@users.noreply.github.com> Date: Tue, 11 Nov 2025 12:26:09 -0800 Subject: [PATCH] [AMD] Apply AITER_MXFP4_MOE_SF=1 only to gfx950 in aiter build (#13092) --- docker/rocm.Dockerfile | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/docker/rocm.Dockerfile b/docker/rocm.Dockerfile index 0f98b1e95..bd059867e 100644 --- a/docker/rocm.Dockerfile +++ b/docker/rocm.Dockerfile @@ -105,12 +105,13 @@ RUN git clone ${AITER_REPO} \ && git checkout ${AITER_COMMIT} \ && git submodule update --init --recursive RUN cd aiter \ + && if [ "$GPU_ARCH" = "gfx950" ]; then export AITER_MXFP4_MOE_SF=1; fi \ && if [ "$BUILD_AITER_ALL" = "1" ] && [ "$BUILD_LLVM" = "1" ]; then \ - HIP_CLANG_PATH=/sgl-workspace/llvm-project/build/bin/ PREBUILD_KERNELS=1 GPU_ARCHS=$GPU_ARCH_LIST AITER_MXFP4_MOE_SF=1 python setup.py develop; \ + sh -c "HIP_CLANG_PATH=/sgl-workspace/llvm-project/build/bin/ PREBUILD_KERNELS=1 GPU_ARCHS=$GPU_ARCH_LIST python setup.py develop"; \ elif [ "$BUILD_AITER_ALL" = "1" ]; then \ - PREBUILD_KERNELS=1 GPU_ARCHS=$GPU_ARCH_LIST AITER_MXFP4_MOE_SF=1 python setup.py develop; \ + sh -c "PREBUILD_KERNELS=1 GPU_ARCHS=$GPU_ARCH_LIST python setup.py develop"; \ else \ - GPU_ARCHS=$GPU_ARCH_LIST AITER_MXFP4_MOE_SF=1 python setup.py develop; \ + sh -c "GPU_ARCHS=$GPU_ARCH_LIST python setup.py develop"; \ fi # ----------------------- @@ -295,7 +296,13 @@ RUN python3 -m pip install --no-cache-dir \ # ----------------------- # Performance environment variable. -ENV AITER_MXFP4_MOE_SF=1 +# Set AITER_MXFP4_MOE_SF only for gfx950 architecture +RUN if [ "$GPU_ARCH" = "gfx950" ]; then \ + echo "AITER_MXFP4_MOE_SF=1"; \ + else \ + echo "AITER_MXFP4_MOE_SF=0"; \ + fi >> /etc/environment + ENV HIP_FORCE_DEV_KERNARG=1 ENV HSA_NO_SCRATCH_RECLAIM=1 ENV SGLANG_ALLOW_OVERWRITE_LONGER_CONTEXT_LEN=1