11
.github/MAINTAINER.md
vendored
11
.github/MAINTAINER.md
vendored
@@ -25,17 +25,24 @@ __Note__: Difference between Merge Oncall and Codeowner
|
||||
- The Codeowner is a passive protection role provided by GitHub; it prevents accidental changes to critical code.
|
||||
- The list of Merge Oncalls is attached below. The list of Codeowners is in the [CODEOWNERS](./CODEOWNERS) file.
|
||||
|
||||
__Note__: The permissions to trigger CI tests are defined separately according to these [rules](https://docs.sglang.ai/developer_guide/contribution_guide.html#how-to-trigger-ci-tests).
|
||||
|
||||
|
||||
## Pull Request Merge Process
|
||||
1. The author submits a pull request (PR) and fills out the PR checklist.
|
||||
2. A bot assigns this PR to a Merge Oncall and @-mentions them. At the same time, GitHub will automatically request reviews from Codeowners.
|
||||
3. The Merge Oncall coordinates the review (e.g., asking people to review) and approves the PR; the relevant Codeowners also approve the PR. If the assigned Merge Oncall is not responsive, the author can ping other related Merge Oncalls and Reviewers in the list below.
|
||||
4. The code can now be merged:
|
||||
3. Someone tags the PR with a `run-ci` label ([help](https://docs.sglang.ai/developer_guide/contribution_guide.html#how-to-trigger-ci-tests)). Then the author can trigger CI by pushing new commits.
|
||||
4. The Merge Oncall coordinates the review (e.g., asking people to review) and approves the PR; the Codeowners also approve the PR. If the assigned Merge Oncall is not responsive, the author can ping other related Merge Oncalls and Reviewers in the list below.
|
||||
5. The code can now be merged:
|
||||
- **Ideal case:** For each modified file, one Codeowner has approved the PR. The PR has also passed the required CI tests. Then, anyone with write permission can merge the PR.
|
||||
- **Exception:** In cases where it is difficult to meet all requirements (due to flaky CI or slow responses), a Merge Oncall can bypass branch protection to merge the PR.
|
||||
|
||||
If you meet any issues during the merge, you can discuss in [slack channels](https://slack.sglang.ai/): #dev, #pull-request, and #ci-cd-build-release.
|
||||
|
||||
## The List of Merge Oncalls and Reviewers
|
||||
The format is @github-username (Slack username).
|
||||
|
||||
TODO: fill in the list.
|
||||
|
||||
Now we have many Merge Oncalls mainly because the CI is flaky and the CODEOWNERS is too coarse-grained.
|
||||
In the future, we hope the CI can be improved and we only need bypass rarely. After that, most Merge Oncalls can be converted back to Write and CODEOWNERS.
|
||||
|
||||
1
.github/workflows/execute-notebook.yml
vendored
1
.github/workflows/execute-notebook.yml
vendored
@@ -6,7 +6,6 @@ on:
|
||||
paths:
|
||||
- "python/sglang/**"
|
||||
- "docs/**"
|
||||
types: [synchronize]
|
||||
workflow_dispatch:
|
||||
|
||||
|
||||
|
||||
1
.github/workflows/lint.yml
vendored
1
.github/workflows/lint.yml
vendored
@@ -5,7 +5,6 @@ on:
|
||||
branches: [main]
|
||||
pull_request:
|
||||
branches: [main]
|
||||
types: [synchronize, labeled]
|
||||
|
||||
jobs:
|
||||
lint:
|
||||
|
||||
1
.github/workflows/pr-benchmark-rust.yml
vendored
1
.github/workflows/pr-benchmark-rust.yml
vendored
@@ -9,7 +9,6 @@ on:
|
||||
branches: [ main ]
|
||||
paths:
|
||||
- "sgl-router/**"
|
||||
types: [synchronize]
|
||||
workflow_dispatch:
|
||||
|
||||
concurrency:
|
||||
|
||||
1
.github/workflows/pr-test-amd.yml
vendored
1
.github/workflows/pr-test-amd.yml
vendored
@@ -19,7 +19,6 @@ on:
|
||||
- "test/**"
|
||||
- "sgl-kernel/**"
|
||||
- ".github/workflows/pr-test-amd.yml"
|
||||
types: [synchronize]
|
||||
workflow_dispatch:
|
||||
|
||||
concurrency:
|
||||
|
||||
1
.github/workflows/pr-test-npu.yml
vendored
1
.github/workflows/pr-test-npu.yml
vendored
@@ -17,7 +17,6 @@ on:
|
||||
- "scripts/ci/**"
|
||||
- "test/**"
|
||||
- ".github/workflows/pr-test-npu.yml"
|
||||
types: [synchronize]
|
||||
workflow_dispatch:
|
||||
|
||||
concurrency:
|
||||
|
||||
1
.github/workflows/pr-test-pd-router.yml
vendored
1
.github/workflows/pr-test-pd-router.yml
vendored
@@ -13,7 +13,6 @@ on:
|
||||
- 'python/sglang/srt/disaggregation/**'
|
||||
- 'scripts/ci/ci_start_disaggregation_servers.sh'
|
||||
- 'sgl-router/**'
|
||||
types: [synchronize]
|
||||
workflow_dispatch:
|
||||
|
||||
concurrency:
|
||||
|
||||
1
.github/workflows/pr-test-rust.yml
vendored
1
.github/workflows/pr-test-rust.yml
vendored
@@ -9,7 +9,6 @@ on:
|
||||
branches: [ main ]
|
||||
paths:
|
||||
- "sgl-router/**"
|
||||
types: [synchronize]
|
||||
workflow_dispatch:
|
||||
|
||||
concurrency:
|
||||
|
||||
1
.github/workflows/pr-test-xeon.yml
vendored
1
.github/workflows/pr-test-xeon.yml
vendored
@@ -21,7 +21,6 @@ on:
|
||||
- "sgl-kernel/**"
|
||||
- ".github/workflows/pr-test-xeon.yml"
|
||||
- "docker/xeon.Dockerfile"
|
||||
types: [synchronize]
|
||||
workflow_dispatch:
|
||||
|
||||
concurrency:
|
||||
|
||||
1
.github/workflows/pr-test-xpu.yml
vendored
1
.github/workflows/pr-test-xpu.yml
vendored
@@ -19,7 +19,6 @@ on:
|
||||
- "test/**"
|
||||
- "sgl-kernel/**"
|
||||
- ".github/workflows/pr-test-xpu.yml"
|
||||
types: [synchronize]
|
||||
workflow_dispatch:
|
||||
|
||||
concurrency:
|
||||
|
||||
1
.github/workflows/pr-test.yml
vendored
1
.github/workflows/pr-test.yml
vendored
@@ -5,7 +5,6 @@ on:
|
||||
branches: [main]
|
||||
pull_request:
|
||||
branches: [main]
|
||||
types: [synchronize]
|
||||
workflow_dispatch:
|
||||
inputs:
|
||||
version:
|
||||
|
||||
1
.github/workflows/quantization-test.yml
vendored
1
.github/workflows/quantization-test.yml
vendored
@@ -17,7 +17,6 @@ on:
|
||||
- "scripts/ci/**"
|
||||
- "test/**"
|
||||
- ".github/workflows/quantization-test.yml"
|
||||
types: [synchronize]
|
||||
workflow_dispatch:
|
||||
|
||||
concurrency:
|
||||
|
||||
Reference in New Issue
Block a user