From 22cbc9c086172c5f47a1107ab2199a5e38887d6a Mon Sep 17 00:00:00 2001 From: Simo Lin Date: Sat, 25 Oct 2025 08:34:43 -0700 Subject: [PATCH] [bugs] docker file name should be .Dockerfile so it can properly render (#11869) --- .github/workflows/pr-test-xeon.yml | 2 +- .github/workflows/pr-test-xpu.yml | 2 +- .github/workflows/release-docker-amd-nightly.yml | 2 +- .github/workflows/release-docker-amd.yml | 2 +- .github/workflows/release-docker-npu-nightly.yml | 4 ++-- .github/workflows/release-docker-npu.yml | 4 ++-- .github/workflows/release-docker-router.yml | 2 +- .github/workflows/release-docker-xeon.yml | 2 +- docker/{Dockerfile.b300 => b300.Dockerfile} | 0 docker/{Dockerfile.npu => npu.Dockerfile} | 0 docker/{Dockerfile.rocm => rocm.Dockerfile} | 6 +++--- docker/{Dockerfile.router => router.Dockerfile} | 0 docker/{Dockerfile.sagemaker => sagemaker.Dockerfile} | 0 docker/{Dockerfile.xeon => xeon.Dockerfile} | 0 docker/{Dockerfile.xpu => xpu.Dockerfile} | 2 +- 15 files changed, 14 insertions(+), 14 deletions(-) rename docker/{Dockerfile.b300 => b300.Dockerfile} (100%) rename docker/{Dockerfile.npu => npu.Dockerfile} (100%) rename docker/{Dockerfile.rocm => rocm.Dockerfile} (98%) rename docker/{Dockerfile.router => router.Dockerfile} (100%) rename docker/{Dockerfile.sagemaker => sagemaker.Dockerfile} (100%) rename docker/{Dockerfile.xeon => xeon.Dockerfile} (100%) rename docker/{Dockerfile.xpu => xpu.Dockerfile} (97%) diff --git a/.github/workflows/pr-test-xeon.yml b/.github/workflows/pr-test-xeon.yml index 75a955a08..f3a6cae7c 100644 --- a/.github/workflows/pr-test-xeon.yml +++ b/.github/workflows/pr-test-xeon.yml @@ -47,7 +47,7 @@ jobs: docker build \ ${PR_REPO:+--build-arg SGLANG_REPO=$PR_REPO} \ ${PR_HEAD_REF:+--build-arg VER_SGLANG=$PR_HEAD_REF} \ - . -f docker/Dockerfile.xeon -t sglang_xeon --no-cache + . -f docker/xeon.Dockerfile -t sglang_xeon --no-cache - name: Run container run: | diff --git a/.github/workflows/pr-test-xpu.yml b/.github/workflows/pr-test-xpu.yml index f4cc7c952..8be3746c5 100644 --- a/.github/workflows/pr-test-xpu.yml +++ b/.github/workflows/pr-test-xpu.yml @@ -46,7 +46,7 @@ jobs: docker build \ ${PR_REPO:+--build-arg SG_LANG_REPO=$PR_REPO} \ ${PR_HEAD_REF:+--build-arg SG_LANG_BRANCH=$PR_HEAD_REF} \ - --no-cache --progress=plain -f docker/Dockerfile.xpu -t xpu_sglang_main:bmg . + --no-cache --progress=plain -f docker/xpu.Dockerfile -t xpu_sglang_main:bmg . - name: Run container id: start_container diff --git a/.github/workflows/release-docker-amd-nightly.yml b/.github/workflows/release-docker-amd-nightly.yml index 12c9d31e7..065774c8c 100644 --- a/.github/workflows/release-docker-amd-nightly.yml +++ b/.github/workflows/release-docker-amd-nightly.yml @@ -61,7 +61,7 @@ jobs: exit 1 fi - docker build . -f docker/Dockerfile.rocm --build-arg BUILD_TYPE=${{ matrix.build_type }} --build-arg GPU_ARCH=${{ matrix.gpu_arch }} -t rocm/sgl-dev:${tag}-${{ env.DATE }}${tag_suffix} --no-cache + docker build . -f docker/rocm.Dockerfile --build-arg BUILD_TYPE=${{ matrix.build_type }} --build-arg GPU_ARCH=${{ matrix.gpu_arch }} -t rocm/sgl-dev:${tag}-${{ env.DATE }}${tag_suffix} --no-cache docker push rocm/sgl-dev:${tag}-${{ env.DATE }}${tag_suffix} cache: diff --git a/.github/workflows/release-docker-amd.yml b/.github/workflows/release-docker-amd.yml index 98c11e2fa..f01349e03 100644 --- a/.github/workflows/release-docker-amd.yml +++ b/.github/workflows/release-docker-amd.yml @@ -52,5 +52,5 @@ jobs: exit 1 fi - docker build . -f docker/Dockerfile.rocm --build-arg BUILD_TYPE=${{ matrix.build_type }} --build-arg GPU_ARCH=${{ matrix.gpu_arch }} -t lmsysorg/sglang:${tag}${tag_suffix} --no-cache + docker build . -f docker/rocm.Dockerfile --build-arg BUILD_TYPE=${{ matrix.build_type }} --build-arg GPU_ARCH=${{ matrix.gpu_arch }} -t lmsysorg/sglang:${tag}${tag_suffix} --no-cache docker push lmsysorg/sglang:${tag}${tag_suffix} diff --git a/.github/workflows/release-docker-npu-nightly.yml b/.github/workflows/release-docker-npu-nightly.yml index 3a1dee3b0..fd2d34e67 100644 --- a/.github/workflows/release-docker-npu-nightly.yml +++ b/.github/workflows/release-docker-npu-nightly.yml @@ -5,7 +5,7 @@ on: - main paths: - ".github/workflows/release-docker-npu-nightly.yml" - - "docker/Dockerfile.npu" + - "docker/npu.Dockerfile" workflow_dispatch: schedule: - cron: "0 0 * * *" @@ -65,7 +65,7 @@ jobs: uses: docker/build-push-action@v6 with: context: docker - file: docker/Dockerfile.npu + file: docker/npu.Dockerfile # TODO: need add x86 platforms support when memfabric is ready platforms: linux/arm64 labels: ${{ steps.meta.outputs.labels }} diff --git a/.github/workflows/release-docker-npu.yml b/.github/workflows/release-docker-npu.yml index 1a6ce903b..221e94ab4 100644 --- a/.github/workflows/release-docker-npu.yml +++ b/.github/workflows/release-docker-npu.yml @@ -9,7 +9,7 @@ on: - main paths: - ".github/workflows/release-docker-npu.yml" - - "docker/Dockerfile.npu" + - "docker/npu.Dockerfile" jobs: build: @@ -61,7 +61,7 @@ jobs: uses: docker/build-push-action@v6 with: context: docker - file: docker/Dockerfile.npu + file: docker/npu.Dockerfile # TODO: need add x86 platforms support when memfabric is ready platforms: linux/arm64 labels: ${{ steps.meta.outputs.labels }} diff --git a/.github/workflows/release-docker-router.yml b/.github/workflows/release-docker-router.yml index f98651e8a..78fde711a 100644 --- a/.github/workflows/release-docker-router.yml +++ b/.github/workflows/release-docker-router.yml @@ -26,5 +26,5 @@ jobs: version=$(cat sgl-router/py_src/sglang_router/version.py | cut -d'"' -f2) tag=v${version} - docker build . -f docker/Dockerfile.router -t lmsysorg/sglang-router:${tag} --no-cache + docker build . -f docker/router.Dockerfile -t lmsysorg/sglang-router:${tag} --no-cache docker push lmsysorg/sglang-router:${tag} diff --git a/.github/workflows/release-docker-xeon.yml b/.github/workflows/release-docker-xeon.yml index bd2a3910f..60e249335 100644 --- a/.github/workflows/release-docker-xeon.yml +++ b/.github/workflows/release-docker-xeon.yml @@ -31,5 +31,5 @@ jobs: version=$(cat python/sglang/version.py | cut -d'"' -f2) tag=v${version}-xeon - docker build . -f docker/Dockerfile.xeon -t lmsysorg/sglang:${tag} --no-cache + docker build . -f docker/xeon.Dockerfile -t lmsysorg/sglang:${tag} --no-cache docker push lmsysorg/sglang:${tag} diff --git a/docker/Dockerfile.b300 b/docker/b300.Dockerfile similarity index 100% rename from docker/Dockerfile.b300 rename to docker/b300.Dockerfile diff --git a/docker/Dockerfile.npu b/docker/npu.Dockerfile similarity index 100% rename from docker/Dockerfile.npu rename to docker/npu.Dockerfile diff --git a/docker/Dockerfile.rocm b/docker/rocm.Dockerfile similarity index 98% rename from docker/Dockerfile.rocm rename to docker/rocm.Dockerfile index f64b28480..0d1a8e9fe 100644 --- a/docker/Dockerfile.rocm +++ b/docker/rocm.Dockerfile @@ -1,7 +1,7 @@ # Usage (to build SGLang ROCm docker image): -# docker build --build-arg SGL_BRANCH=v0.5.4 --build-arg GPU_ARCH=gfx942 -t v0.5.4-rocm630-mi30x -f Dockerfile.rocm . -# docker build --build-arg SGL_BRANCH=v0.5.4 --build-arg GPU_ARCH=gfx942-rocm700 -t v0.5.4-rocm700-mi30x -f Dockerfile.rocm . -# docker build --build-arg SGL_BRANCH=v0.5.4 --build-arg GPU_ARCH=gfx950 -t v0.5.4-rocm700-mi35x -f Dockerfile.rocm . +# docker build --build-arg SGL_BRANCH=v0.5.4 --build-arg GPU_ARCH=gfx942 -t v0.5.4-rocm630-mi30x -f rocm.Dockerfile . +# docker build --build-arg SGL_BRANCH=v0.5.4 --build-arg GPU_ARCH=gfx942-rocm700 -t v0.5.4-rocm700-mi30x -f rocm.Dockerfile . +# docker build --build-arg SGL_BRANCH=v0.5.4 --build-arg GPU_ARCH=gfx950 -t v0.5.4-rocm700-mi35x -f rocm.Dockerfile . # Default base images diff --git a/docker/Dockerfile.router b/docker/router.Dockerfile similarity index 100% rename from docker/Dockerfile.router rename to docker/router.Dockerfile diff --git a/docker/Dockerfile.sagemaker b/docker/sagemaker.Dockerfile similarity index 100% rename from docker/Dockerfile.sagemaker rename to docker/sagemaker.Dockerfile diff --git a/docker/Dockerfile.xeon b/docker/xeon.Dockerfile similarity index 100% rename from docker/Dockerfile.xeon rename to docker/xeon.Dockerfile diff --git a/docker/Dockerfile.xpu b/docker/xpu.Dockerfile similarity index 97% rename from docker/Dockerfile.xpu rename to docker/xpu.Dockerfile index a50de5bf4..8030d58cf 100644 --- a/docker/Dockerfile.xpu +++ b/docker/xpu.Dockerfile @@ -1,6 +1,6 @@ # If the device is Battlemage, we need to set UBUNTU_VERSION to 24.10 -# Usage: docker build --build-arg UBUNTU_VERSION=24.04 --build-arg PYTHON_VERSION=3.10 -t sglang:xpu_kernel -f Dockerfile.xpu --no-cache . +# Usage: docker build --build-arg UBUNTU_VERSION=24.04 --build-arg PYTHON_VERSION=3.10 -t sglang:xpu_kernel -f xpu.Dockerfile --no-cache . # Use Intel deep learning essentials base image with Ubuntu 24.04 FROM intel/deep-learning-essentials:2025.1.3-0-devel-ubuntu24.04